[RFC] xserver: rip indexes out of the API/ABI

[Dave Airlie]

On Thu, Apr 26, 2012 at 1:10 AM, Aaron Plattner <aplattner at nvidia.com> wrote:
> On 04/10/2012 02:10 PM, Alan Coopersmith wrote:
>>
>> On 04/10/12 07:47 AM, Dave Airlie wrote:
>>>
>>> This patch series tears strips out of the current API, its not complete,
>>> with further changes to ddc/i2c code I can remove all references to
>>> xf86Screens from drivers. I've got a bit more work to stop them
>>> peaking inside screenInfo.
>>
>>
>> And of course I went through them all before noticing it was just an RFC,
>> not a full review - that said, I'm pretty okay with them, other than the
>> handful of docs notes and the couple of questions I asked about
>> consistency.
>
>
> I just skimmed all the changes, and they don't look particularly horrible.
>  It'll require some #ifdeffery on my part, but I can live with that.
>
> However, actually removing screenInfo.screens and screenInfo.numScreens is
> going to get tricky because there are a bunch of cases where we have to
> either compare screen numbers in protocol against numScreens and then look
> up a pScreen from there, or where we have to loop over all screens.  A
> dixForAllScreens / xf86ForAllScrnInfos iterator would solve the latter, but
> I don't know what the right plan is for the former.

Yeah I understand that area, and if the driver wants to engage in
hotplug it'll just have to grow support for dealing with transitioning
from protocol screens to gpu screens. So I don't think I can remove
screenInfo from the ABI but I'd like to reduce its use to being purely
at protocol extension level.

>
> I'm going to suppress the urge to complain about API cleanups that cause me
> to have to add #ifdefs to our code and try to look at this objectively.  :)
>  From an API cleanup standpoint, I think this is a good step.

Well since I have to convert the whole X.org driver set, I think I'd
much rather not do this either, but it suddenly makes hotplug so much
less painful than my first two attempts, that I feel its worth it.

Dave.