Multitouch regression in 3.3 on thinkpad X220 clickpad

Daniel Drake dsd at laptop.org
Sat Apr 21 08:03:01 PDT 2012


On Fri, Apr 20, 2012 at 6:16 PM, Benjamin Herrenschmidt
<benh at kernel.crashing.org> wrote:
>> It looks we lost a condition in synaptics_set_advanced_gesture_mode().
>> It used to be:
>>
>>
>>       if (!(SYN_CAP_ADV_GESTURE(priv->ext_cap_0c) ||
>>                       SYN_CAP_IMAGE_SENSOR(priv->ext_cap_0c)))
>>               return 0;
>>
>> and now simply is:
>>
>>       if (!SYN_CAP_ADV_GESTURE(priv->ext_cap_0c))
>>               return 0;
>>
>> Could you try restoring the condition and see if it fixes the
>> regression?
>
> Yes, that's it. Please shoot the patch below to Linus.

Oops. Thanks Ben and Dmitry, and apologies for causing this bug.

Daniel


More information about the xorg-devel mailing list