[PATCH 09/10] Save physical button state for emulated touches too

[Peter Hutterer]

On Wed, Apr 18, 2012 at 07:16:57AM -0700, Chase Douglas wrote:
> On 04/17/2012 11:41 PM, Peter Hutterer wrote:
> > On Tue, Apr 17, 2012 at 04:33:28PM -0700, Chase Douglas wrote:
> >> The physical button state is reported by XIQueryPointer for clients
> > 
> > this should read "logical button state" and I believe TouchClassRec::state
> > already has exactly this information, right?
> 
> I copied the mechanism currently used for button events in
> UpdateDeviceState. It's fairly clear that the button "mask", used for
> QueryPointer, is the logical button state, but the button "down"
> variable holds the physical button state. The protocol isn't clear on
> which state is reported.
> 
> So do we need to fix the state so it reports the logical buttons down?

All requests work on the logical state only, the physical state is mostly
hidden from the clients because it shouldn't matter.

button->down is the physical state, it's in this case that XIQueryPointer is
broken.

Cheers,
  Peter