[PATCH 00/11] Implement GLX_ARB_create_context

Ian Romanick idr at freedesktop.org
Tue Apr 17 08:39:52 PDT 2012


On 04/17/2012 03:07 AM, Christopher James Halse Rogers wrote:
> On Fri, 2012-04-13 at 18:11 -0700, Ian Romanick wrote:
>> This is mostly a re-send of my previous patch series.  I have
>> incorporated all (I think?) of the previous review comments, and I
>> have (mostly) applied the new indent rules.
>>
>> I have tested with all of the piglit GLX_ARB_create_context tests.
>> There are two failures.  One is a case of returning the wrong error
>> code (which may actually be an error in the spec), and the other is a
>> client bug.
>>
>> Once these are applied, patches to implement
>> GLX_ARB_create_context_profile and GLX_EXT_create_context_es2_profile
>> will follow shortly.
>>
>
> With the exception of the (minor) issues on the three patches,
> Reviewed-By: Christopher James Halse Rogers
> <christopher.halse.rogers at canonical.com>

Thanks for the review!

I've pushed an updated set of patches to the GLX_ARB_create_context 
branch of my local git repo 
(git://people.freedesktop.org/~idr/xserver.git).  Assuming my changes 
for your review comments are good, I'll send a pull request to Keith.


More information about the xorg-devel mailing list