[PATCH 14/15] xf86: migrate PointerMoved from index to ScrnInfoPtr (ABI/API)

Dave Airlie airlied at gmail.com
Tue Apr 10 23:05:08 PDT 2012


On Tue, Apr 10, 2012 at 10:05 PM, Alan Coopersmith
<alan.coopersmith at oracle.com> wrote:
> On 04/10/12 07:47 AM, Dave Airlie wrote:
>> -    ScreenPtr pScreen = screenInfo.screens[scrnIndex];
>> -    ScrnInfoPtr pScrn = XF86SCRNINFO(pScreen);
>> +    ScreenPtr pScreen = xf86ScrnToScreen(pScrn);
>
> Should the remaining instances of XF86SCRNINFO be replaced?
> It appears to be roughly equivalent to xf86ScreenToScrn, but
> implemented via dixLookupPrivate instead of via an array index lookup.

Yeah I was going to nuke those + any pScrn->pScreen direct conversions.

Then if I embed the Screen into the ScrnInfo I can make the conversion
functions trivial.

Dave.


More information about the xorg-devel mailing list