[PATCH v3] os: Add -displayfd option

Adam Jackson ajax at redhat.com
Thu Apr 5 07:46:42 PDT 2012


On Thu, 2012-04-05 at 09:39 +0100, Daniel Stone wrote:
> Hi,
> 
> On 5 April 2012 06:19, Chase Douglas <chase.douglas at canonical.com> wrote:
> > On 04/04/2012 07:18 PM, Alan Coopersmith wrote:
> >> Thanks.   (I do note that you removed the \n from the display and
> >> didn't add it to the write of the display to the fd - I don't know
> >> if that matters or not, so figured I'd mention it.)
> >
> > Oh, I forgot to mention the change. Thanks for catching it.
> >
> > I don't see any reason the '\n' should be necessary.
> 
> It's a good way to know you've not got a partial write, and that the
> display really is :1 rather than the first two bytes of :137.

I guess?  Except right after that we close() it, and EOF's a pretty
solid delimiter.

Not a big deal either way, but probably the \n is slightly more paranoid
in case the launcher's string library expects newline termination.

- ajax
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20120405/c586fbe8/attachment.pgp>


More information about the xorg-devel mailing list