[PATCH v3] os: Add -displayfd option

Alan Coopersmith alan.coopersmith at oracle.com
Wed Apr 4 19:18:47 PDT 2012


On 04/ 4/12 03:29 PM, Chase Douglas wrote:
> This option specifies a file descriptor in the launching process.  X
> will scan for an available display number and write that number back to
> the launching process, at the same time as SIGUSR1 generation.  This
> means display managers don't need to guess at available display numbers.
> As a consequence, if X fails to start when using -displayfd, it's not
> because the display was in use, so there's no point in retrying the X
> launch on a higher display number.
> 
> Signed-off-by: Adam Jackson <ajax at redhat.com>
> Signed-off-by: Chase Douglas <chase.douglas at canonical.com>
> Reviewed-by: Julien Cristau <jcristau at debian.org>
> Tested-by: Julien Cristau <jcristau at debian.org>
> ---
> Changes since v2:
> * Use snprintf instead of sprintf (in both locations)
> * Add a comment about how the display global variable is set

Thanks.   (I do note that you removed the \n from the display and
didn't add it to the write of the display to the fd - I don't know
if that matters or not, so figured I'd mention it.)

Reviewed-by: Alan Coopersmith <alan.coopersmith at oracle.com>

-- 
	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc


More information about the xorg-devel mailing list