ast driver patches

Y.C. Chen yc_chen at aspeedtech.com
Tue Apr 3 03:18:14 PDT 2012


Hi Dave,
I am so sorry about that and thanks for your comment. I tried to re-commit 
the updates, if it is still un-acceptable, please let me know, I will try to 
correct it.

Regards,

Y.C. Chen

-----原始郵件----- 
From: Dave Airlie
Sent: Tuesday, April 03, 2012 5:08 PM
To: xorg-devel at lists.x.org ; yc_chen at aspeedtech.com
Subject: ast driver patches

Hi,

I'm not sure what you think you are up to with the -ast driver but one
thing you aren't doing is making it any better.

a) Please STOP pushing all-in-one patches to as root. NO MORE
root at localhost.localdomain. If you don't know how to use git, please
ask or read a tutorial.

b) Please push distinct changes. with proper git changelogs, take a
look at the -ati, -intel driver, there is one commit per change, and
there is an explanation of what it does.

I'm reverting the changes you pushed as it makes it impossible for
downstream to document what has changed and what fixes are in the
driver.

If you cannot commit to doing proper code commits we'll have to
restrict commit access and have you submit patches to the mailing list
until you are ready to maintain the tree.

What you are doing now is totally unacceptable.

Dave. 



More information about the xorg-devel mailing list