[resend PATCH] sdksyms.sh may not be executable.

[Matthieu Herrb]

On Fri, Sep 30, 2011 at 09:25:09AM -0400, Gaetan Nadon wrote:
> On Fri, 2011-09-30 at 14:36 +0200, Matthieu Herrb wrote:
> 
> > Use $(SHELL) to run it.
> > 
> > Signed-off-by: Matthieu Herrb <matthieu.herrb at laas.fr>
> > ---
> >  hw/xfree86/Makefile.am |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/hw/xfree86/Makefile.am b/hw/xfree86/Makefile.am
> > index e3ef14f..4f08772 100644
> > --- a/hw/xfree86/Makefile.am
> > +++ b/hw/xfree86/Makefile.am
> > @@ -111,7 +111,7 @@ CLEANFILES = sdksyms.c sdksyms.dep
> >  EXTRA_DIST += sdksyms.sh
> >  
> >  sdksyms.dep sdksyms.c: sdksyms.sh
> > -	CPP='$(CPP)' AWK='$(AWK)' $(srcdir)/sdksyms.sh $(top_srcdir) $(CFLAGS) $(AM_CFLAGS) $(INCLUDES)
> > +	CPP='$(CPP)' AWK='$(AWK)' $(SHELL) $(srcdir)/sdksyms.sh $(top_srcdir) $(CFLAGS) $(AM_CFLAGS) $(INCLUDES)
> >  
> >  SDKSYMS_DEP = sdksyms.dep
> >  include $(SDKSYMS_DEP)
> 
> 
> For the benefit of the readers, can you mention in the commit text under
> which circumstances the script is not executable?
> Doesn't git work the same way on all platforms? rwxr-xr-x sdksyms.sh
> 
> In hw/xquartz/bundle
> install-data-hook:
> 
> 	$(srcdir)/mk_bundke.sh $(srcdir)
> 
Probably the Xquartz one should be fixed too.

> I am sure there is a good reason,

Ok I'll add this:

"Someone may want to build out of a source tree in a filesystem with
the noexec mount flag set."

And some further details: 

My main reason is that we re-import the X.Org sources in a
different VCS in the OpenBSD project and has the policy that no
file should be executable there.
sdksyms is the only case for builds on OpenBSD where as script is used
directly (ie autotools knows about this and use ${SHELL} where needed
in their generated files.

> 
> Reviewed-by: Gaetan Nadon <memsize at videotron.ca>

Thanks.

-- 
Matthieu Herrb