[PATCH] Remove incorrect & in swap_uint32

Aaron Plattner aplattner at nvidia.com
Wed Sep 28 14:32:38 PDT 2011


On 09/28/2011 02:27 PM, Matt Turner wrote:
> Caused by commit 893e86a4, and hidden by the (char *) cast.
>
> Signed-off-by: Matt Turner<mattst88 at gmail.com>

Reviewed-by: Aaron Plattner <aplattner at nvidia.com>

This also fixes the XTS UNRESOLVED results, so

Tested-by: Aaron Plattner <aplattner at nvidia.com>

> ---
>   include/misc.h |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/misc.h b/include/misc.h
> index 1fea73e..180b3c1 100644
> --- a/include/misc.h
> +++ b/include/misc.h
> @@ -277,7 +277,7 @@ static inline void __builtin_constant_p(int x)
>   /* byte swap a 32-bit value */
>   static inline void swap_uint32(uint32_t *x)
>   {
> -	char n = ((char *)&x)[0];
> +	char n = ((char *) x)[0];
>   	((char *) x)[0] = ((char *) x)[3];
>   	((char *) x)[3] = n;
>   	n = ((char *) x)[1];


More information about the xorg-devel mailing list