[PATCH resend 1/3] Quit wrapping ChangeClip, CopyClip, and DestroyClip in GCFuncs.

Jamey Sharp jamey at minilop.net
Wed Sep 28 11:48:18 PDT 2011

On Wed, Sep 28, 2011 at 11:02:42AM -0700, Aaron Plattner wrote:
> Xserer-spec.xml still lists ChangeClip in the "mi" section in the
> list of server routines for porting, and DestroyClip in the "ddx"
> section.

Good catch! Amended locally and on my published review-pending branch,

> Can't you drop the CT_PIXMAP case in xnestChangeClip?  I guess it
> doesn't actually matter since it's just dead code and it gets
> removed in patch 2/3 anyway...

Yeah, I didn't want to make the assumption that CT_PIXMAP wasn't used
until I could first assume that only the mi implementation of clip
management needed review, so I think the series stands better in this

> Other than that,
> Reviewed-by: Aaron Plattner <aplattner at nvidia.com>

Thank you! This patch and my fix to make kdrive build again are now on
my "reviewed" branch, ready for Keith to pull, though I'll wait a bit to
see if you're reviewing the other two patches. :-)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110928/ecdd78f8/attachment.pgp>

More information about the xorg-devel mailing list