[PATCH:libxtrans 00/10] Warning cleanups

Jeremy Huddleston jeremyhu at apple.com
Wed Sep 28 10:22:45 PDT 2011


Series Reviewed-by: Jeremy Huddleston <jeremyhu at apple.com>

On Sep 27, 2011, at 2:28 PM, Alan Coopersmith wrote:

> These greatly reduce the warning noise generated by the libxtrans code
> when building the X server, libX11, and other modules using libxtrans.
> 
> Alan Coopersmith (10):
>  Fix warnings about static functions declared but never defined
>  Convert PRMSG macro to prmsg inline function
>  Fix printf format string warnings
>  Fix warning: ISO C90 forbids mixed declarations and code
>  Fix unused variable warnings
>  Mark __xtransname strings for debug messages as const char *
>  Add _X_UNUSED attributes to silence unused parameter warnings
>  Fix warning: unused variable 'tmpport' with various configurations
>  Add const attributes to fix gcc -Wwrite-strings warnings
>  Convert a bunch of sprintf calls to snprintf
> 
> Xtrans.c     |  135 +++++++++++-----------
> Xtrans.h     |   20 ++--
> Xtransint.h  |  115 ++++++++++--------
> Xtranslcl.c  |  369 ++++++++++++++++++++++++++++-----------------------------
> Xtranssock.c |  336 +++++++++++++++++++++++++----------------------------
> Xtranstli.c  |  283 +++++++++++++++++++++-----------------------
> Xtransutil.c |   59 +++++-----
> transport.c  |    3 +
> 8 files changed, 650 insertions(+), 670 deletions(-)
> 
> -- 
> 1.7.3.2
> 
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
> 



More information about the xorg-devel mailing list