[Pull Request] Glamor: A 2D rendering acceleration implementation based on OpenGL

Alan Coopersmith alan.coopersmith at oracle.com
Tue Sep 27 11:05:12 PDT 2011

[Fixed cc to xorg-devel instead of xorg, since xorg is for discussing usage,
  xorg-devel where we discuss changes to the code - the same goes for the IRC
  channels btw.]

Well, you request reviews by mailing xorg-devel and asking for them, not
skipping straight to "This is ready to merge to master, pull it in."

Just a quick glance through git log -p output on a local pull of that branch
shows it's not ready for merging - there's tons of highlighted whitespace
errors and some obvious style inconsistencies with the existing code base,
as well as with itself.  (Some files switch back and forth between different
amounts of space per indent level between different functions or even in the
same function.)

It would also be nice if it built, but my attempt to do so fails with:
  "glamor_ddx.c", line 34: cannot find include file: <gbm.h>
which suggests more work is needed on the configure.ac checks.


On 09/27/11 09:19 AM, zhigang gong wrote:
> Alan,
> Thanks for your comments.Yes, I agree with you that glamor need more reviews
> before it can be merged in. Because of some historic reason, glamor hasn't
> been developed in a open way. I want to change it from now on. Actually
> I discussed with Keith and Eric last week, and as some how glamor is
> a standalone module and will not affect too many other parts, Keith suggested
> me to submit this pull request soon, and ask comments from community.
> On Tue, Sep 27, 2011 at 11:39 PM, Alan Coopersmith
> <alan.coopersmith at oracle.com>  wrote:
>> On 09/27/11 06:50 AM, zhigang gong wrote:
>>>   [Over 225 commits]
>>>   47 files changed, 10484 insertions(+), 14 deletions(-)
>> That's a huge amount of change without any Reviewed-by: tags, which
>> makes it seem very premature for requesting a Pull, especially as it's
>> the first time xorg-devel has really ever heard of this project.
>> --
>>         -Alan Coopersmith-        alan.coopersmith at oracle.com
>>          Oracle Solaris Platform Engineering: X Window System

	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System

More information about the xorg-devel mailing list