[PATCH] Remove another if (E != NULL) check around free(E)

Jamey Sharp jamey at minilop.net
Mon Sep 26 21:11:47 PDT 2011


Reviewed-by: Jamey Sharp <jamey at minilop.net>

On Mon, Sep 26, 2011 at 10:58:24PM -0400, Matt Turner wrote:
> I wonder if there are any other patterns we haven't seen yet?
> 
> Signed-off-by: Matt Turner <mattst88 at gmail.com>
> ---
>  hw/xfree86/fbdevhw/fbdevhw.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/xfree86/fbdevhw/fbdevhw.c b/hw/xfree86/fbdevhw/fbdevhw.c
> index dee731b..fbda349 100644
> --- a/hw/xfree86/fbdevhw/fbdevhw.c
> +++ b/hw/xfree86/fbdevhw/fbdevhw.c
> @@ -99,8 +99,6 @@ fbdevHWFreeRec(ScrnInfoPtr pScrn)
>  {
>  	if (fbdevHWPrivateIndex < 0)
>  		return;
> -	if (FBDEVHWPTR(pScrn) == NULL)
> -		return;
>  	free(FBDEVHWPTR(pScrn));
>  	FBDEVHWPTRLVAL(pScrn) = NULL;
>  }
> -- 
> 1.7.3.4
> 
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110926/1024945a/attachment.pgp>


More information about the xorg-devel mailing list