[PATCH xf86-video-mga 1/4] Remove xalloc/xcalloc/xrealloc/xfree

Jamey Sharp jamey at minilop.net
Mon Sep 26 21:11:07 PDT 2011


On Mon, Sep 26, 2011 at 10:41:49PM -0400, Matt Turner wrote:
> --- a/src/mga_video.c
> +++ b/src/mga_video.c
> @@ -131,8 +131,7 @@ void MGAInitVideo(ScreenPtr pScreen)
>  	    num_adaptors = 1;
>  	    adaptors = &newAdaptor;
>  	} else {
> -	    newAdaptors =  /* need to free this someplace */
> -		xalloc((num_adaptors + 1) * sizeof(XF86VideoAdaptorPtr*));
> +	    newAdaptors = malloc((num_adaptors + 1) * sizeof(XF86VideoAdaptorPtr *));

Why did you delete this comment?

Otherwise,

Reviewed-by: Jamey Sharp <jamey at minilop.net>

If you'd produce another patch to delete all instances of casting the
return value of malloc/calloc/realloc, that would be awesome. We have
(void *) now...

Jamey
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110926/b011744d/attachment.pgp>


More information about the xorg-devel mailing list