[PATCH xf86-video-chips] Build fixes for ABI_VIDEODRV_VERSION 12

Mark Kettenis mark.kettenis at xs4all.nl
Mon Sep 26 12:43:41 PDT 2011


> From: Jeremy Huddleston <jeremyhu at apple.com>
> Date: Sat, 24 Sep 2011 12:24:56 -0700
> 
> On Sep 24, 2011, at 05:28, Mark Kettenis wrote:
> 
> >> That doesn't help us.  PCITAG is gone, and CARD32 is being used
> >> instead.  XSERVER_LIBPCIACCESS is still defined.  Perhaps *both*
> >> changes are necessary.
> > 
> > Look again please.  It's #ifndef XSERVER_LIBPCIACCESS, so PCITAG will
> > only be needed if you're compiling against an ancient pre-libpciaccess
> > xserver that doesn't define XSERVER_LIBPCIACCESS.
> 
> Ah, yes.  That n is importatnt.  Perhaps I should've waited to
> respond in the morning rather than 4am =)

No problem.  Just sent a proper git-formatted diff to the list, since
I think this is the right thing to do regardless of whether PCITAG
gets removed or not.


More information about the xorg-devel mailing list