Maintaining backwards compatibility with swap macros
jamey at minilop.net
Sun Sep 25 12:59:57 PDT 2011
On Sun, Sep 25, 2011 at 01:50:01PM -0400, Matt Turner wrote:
> Dave pointed out that there are a couple drivers (sis, sisusb, vmware)
> that use the swapl/swaps macros. My recent patch series dropped the n
> argument from the macros, causing these drivers to not build.
> Ideally, we'd like a deprecation warning when the second argument is
> given, but by removing the second argument, we'd lose compatibility with
> old servers.
> We could modify the swap macros in the server with the following patch,
> or we could update the drivers to use a single argument
> #if XORG_VERSION_CURRENT > XORG_VERSION_NUMERIC(1, 11, 99, 0).
I'd vote for fixing the drivers in a conditional. Hiding
wrong-number-of-arguments bugs seems bad to me.
If you want to be *clever*, though:
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: Digital signature
More information about the xorg-devel