[PATCH-V2] xserver: Optional backtrace handler

[Alan Coopersmith]

On 09/23/11 05:23 AM, Barry Scott wrote:
> On Friday 23 September 2011 10:40:35 Simon Farnsworth wrote:
> <snip>
>
> > > diff --git a/include/os.h b/include/os.h
> > > index a553f57..48debe9 100644
> > > --- a/include/os.h
> > > +++ b/include/os.h
> > > @@ -542,5 +542,8 @@ extern _X_EXPORT void Error(const char *str);
> > > extern _X_EXPORT void LogPrintMarkers(void);
> > >
> > > extern _X_EXPORT void xorg_backtrace(void);
> > > +extern _X_EXPORT void xorg_init_backtrace(void);
> > > +extern _X_EXPORT void xorg_cleanup_backtrace(void);
> > > +extern const char *BacktraceHandlerPath;
> > >
> >
> > I still think these ought to be _X_HIDDEN or _X_INTERNAL, rather than
> > _X_EXPORT - they shouldn't be called by modules, for example.
> >
>
>
> Can one of the Xorg knowledge developers comment on this please?
>
> What attribute should be used?

I agree they should be _X_HIDDEN since they're not part of the API we want
to export from the server.   We don't really use _X_INTERNAL.

-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System