[PATCH] dix: Prevent access to freed memory if a client kills itself.

Rami Ylimäki rami.ylimaki at vincit.fi
Fri Sep 23 00:28:12 PDT 2011

On 09/22/2011 07:34 PM, Jamey Sharp wrote:
> This patch makes sense to me, but I have a couple of requests:
> I'm not sure why you extracted out a separate function; I'm not
> convinced that makes the code more clear, in this case.

Originally, there was no good reason for extracting the code to a 
separate function. However, I'm currently suspecting that a certain XACE 
(https://meego.gitorious.org/maemo-multimedia/xserver-policy-enforcement) might 
be suffering from the same problem. In this case I'd want to have a 
separate function and export it as well so that I wouldn't have to 
copy-paste its contents into the XACE module. If it turns out that XPE 
works fine, I can remove that function in the next patch revision.

> More importantly, I'd like to see justification in the commit message
> for deleting LBX support here. I seem to recall that support was
> deleted from the rest of the server already, which would be excellent
> justification, but please say so if that's true.

To be honest, I didn't know what LBX was when I wrote the patch and 
didn't take into account the effect of extensions on closing down 
clients. But it seems that LBX has been gone for 5 years now, so I can 
clarify this in the commit message of the next patch revision.

-- Rami

More information about the xorg-devel mailing list