[PATCH v2] Address regressions from e8ff555b95baab66cc7d060c1e7f9fdd49d3802f

Jeremy Huddleston jeremyhu at apple.com
Thu Sep 22 21:55:34 PDT 2011


On Sep 22, 2011, at 20:23, Jamey Sharp wrote:

> Reviewed-by: Jamey Sharp <jamey at minilop.net>
> 
> What I said for Alan's patch goes for this one too:
> 
> Seems like there ought to be a better way than listing which compilers
> support it, though. I considered an autoconf test to check whether
> __builtin_constant_p is defined, but that doesn't tell you which
> compiler is pulling in misc.h each time it's used. Which wouldn't be an
> issue if misc.h weren't part of the SDK headers. Phooey.

Yeah, I'm certainly in favor of "something better" but for now, I settle for "something working" =/



More information about the xorg-devel mailing list