[PATCH xinput 1/1] Support the new Scroll class

Daniel Stone daniel at fooishbar.org
Thu Sep 22 03:17:20 PDT 2011


On Mon, Aug 22, 2011 at 03:35:23PM +1000, Peter Hutterer wrote:
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>

Reviewed-by: Daniel Stone <daniel at fooishbar.org>

However ...

> +# XI2.1 support
> +PKG_CHECK_MODULES(XI21, [xi >= 1.4.99.1] [inputproto >= 2.0.99.1],
> +                  HAVE_XI21="yes"; AC_DEFINE(HAVE_XI21, 1, [XI2.1 available]),
> +                  HAVE_XI21="no");
> +AM_CONDITIONAL(HAVE_XI21, [ test "$HAVE_XI21" = "yes" ])
> +AC_SUBST(HAVE_XI21)

You don't need the AM_CONDITIONAL/AC_SUBST here as you're not using
HAVE_XI21 in any Makefile fragments.  So you can remove those two as
well as the HAVE_XI21 and just simplify it to a
PKG_CHECK_MODULES(XI21, ..., AC_DEFINE(HAVE_XI21, 1, ...)).

Cheers,
Daniel


More information about the xorg-devel mailing list