[PATCH evdev 1/1] Support smooth scrolling on REL_WHEEL, REL_HWHEEL and REL_DIAL

[Daniel Stone]

Hi,

On Mon, Aug 22, 2011 at 03:35:15PM +1000, Peter Hutterer wrote:
> +#ifdef HAVE_SMOOTH_SCROLLING
> +        if (axis == REL_WHEEL)
> +            SetScrollValuator(device, axnum, SCROLL_TYPE_VERTICAL, 1.0, SCROLL_FLAG_PREFERRED);
> +        else if (axis == REL_DIAL)
> +            SetScrollValuator(device, axnum, SCROLL_TYPE_VERTICAL, 1.0, SCROLL_FLAG_NONE);

This will break scroll emulation on devices which have a dial but not a
vertical wheel.

> +        else if (axis == REL_HWHEEL)
> +            SetScrollValuator(device, axnum, SCROLL_TYPE_HORIZONTAL, 1.0, SCROLL_FLAG_NONE);
> +#endif

And this should be _PREFERRED, no? (See inputproto review.)

Cheers,
Daniel