[PULL] bswap cleanup and misc patches

Matt Turner mattst88 at gmail.com
Wed Sep 21 14:17:18 PDT 2011

On Wed, Sep 21, 2011 at 4:43 PM, Keith Packard <keithp at keithp.com> wrote:
> On Fri, 2 Sep 2011 19:05:28 -0400, Matt Turner <mattst88 at gmail.com> wrote:
>> Please pull from my tree. It contains four miscellaneous patches that
>> were reviewed months ago and clean ups to the bswap macros.
> Thanks for the nice cleanup work; this has been needed for twenty years
> :-)
>> Matt Turner (12):
>>       Use abs() on integers, not fabs()
>>       Remove unnecessary #undefs of [f]abs and old comments
>>       Replace Fabs() macro with fabs() function
>>       Silence printf format warnings in helper_exec.c
>>       Use internal temp variable for swap macros
>>       Use correct swap{l,s} (or none at all for CARD8)
>>       Cast char* buffers to swap functions
>>       Introduce swap_uint{16,32} functions, used in swap{l,s}
>>       Add type checking to swap macros
>>       Make lswap{l,s} inline functions
>>       Use lswap{l,s} in cpswap{l,s}
>>       Use __builtin_constant_p to determine if we can use lswapl
>> Peter Harris (1):
>>       xkb: add missing swaps for xkbGetDeviceInfoReply
> Looks like hw/dmx was missed in your testing? With this patch added, I
> get a clean build. Could I get you to merge this in at the right place?

Looks like I missed dmx. Thanks for the patch. I've updated "Use
correct swap{l,s} (or none at all for CARD8)" to include your changes.

I updated the for-keith branch in-place, so it's good to go now.


More information about the xorg-devel mailing list