Bus layer cleanups
jeremyhu at apple.com
Tue Sep 20 20:00:18 PDT 2011
Comparing the end result of this patchset before and after the cleanup reveals this change. Was this intentional or did something slip through when restructuring?
$ git diff c70241de29ae9c80a89be29e16b838b14a83445e 5057dc2020e8854a97570442bc897a87b4fb8ac2
diff --git a/hw/xfree86/vgahw/vgaHW.c b/hw/xfree86/vgahw/vgaHW.c
index 2ce6352..aab2ae2 100644
@@ -1707,6 +1707,7 @@ vgaHWGetHWRec(ScrnInfoPtr scrp)
hwp->MapSize = 0;
hwp->pScrn = scrp;
+ hwp->PIOOffset = scrp->domainIOBase;
hwp->dev = xf86GetPciInfoForEntity(scrp->entityList);
On Sep 20, 2011, at 3:19 PM, Matt Turner wrote:
> On Tue, Sep 20, 2011 at 11:03 AM, Matt Turner <mattst88 at gmail.com> wrote:
>> On Mon, Sep 19, 2011 at 3:23 AM, Jamey Sharp <jamey at minilop.net> wrote:
>>> I've built each patch in the series and minimally tested that each
>>> resulting server works with the xf86-video-nested driver, a window
>>> manager, and an xterm. That means I'm not testing most of the changed
>>> code paths, but I'm doing what I can on this airplane...
>>> Patches 3 and 4 don't compile because 'scrp' is not in scope in
>>> vgaHWSetStdFuncs. The series fixes it in patch 5 by deleting this
>>> reference to hwp->PIOOffset and scrp->domainIOBase entirely, but bisect
>>> fails on these two.
>>> Patches 14 and 15 introduce some warnings like:
>>> vgaHW.c:1761:5: warning: implicit declaration of function 'pci_device_map_legacy'
>> These things I'll handle. I'll send another email with an updated branch.
> Dropped patch 3 and rebased patches 4 and 5. Pushed to the same
> branch, git://people.freedesktop.org/~mattst88/xserver ioaddress
- Board of Directors
Berkeley Foundation for Opportunities in Information Technology
- Advisory Board
More information about the xorg-devel