Bus layer cleanups

Jamey Sharp jamey at minilop.net
Sun Sep 18 20:23:15 PDT 2011

I've built each patch in the series and minimally tested that each
resulting server works with the xf86-video-nested driver, a window
manager, and an xterm. That means I'm not testing most of the changed
code paths, but I'm doing what I can on this airplane...

Patches 3 and 4 don't compile because 'scrp' is not in scope in
vgaHWSetStdFuncs. The series fixes it in patch 5 by deleting this
reference to hwp->PIOOffset and scrp->domainIOBase entirely, but bisect
fails on these two.

Patches 14 and 15 introduce some warnings like:

vgaHW.c:1761:5: warning: implicit declaration of function 'pci_device_map_legacy'

Otherwise, under my minimal testing this series all works fine. I have
not reviewed the patches in any detail though, though the cursory glance
I've given each one looks pretty good.

Adam, what's incomplete about patch 16?


On Fri, Sep 16, 2011 at 01:50:06PM -0400, Matt Turner wrote:
> ajax sent the original series out in Sept 2010 and has added some
> more on top of it since then.
> His original message was
> On Sep 21, 2010, at 6:28 PM, Adam Jackson wrote:
> > This attempts to tackle Tiago's (justified) hatred for the IOADDRESS type
> > in a slightly more elegant way.  We move more of the VGA hacks to vgahw,
> > port it and int10 over to pciaccess' legacy I/O API, and then clean up
> > some of the remaining detritus.
> >
> > THIS IS AN ABI BREAK.  Like, a pretty massive one.  Please do not pull
> > this yet.  I'm mostly looking for r-b's here that the strategy looks
> > sane.  The driver work needs to land before this lands, and it's pretty
> > trivial, but I don't want to bother unless this is actually going to
> > merge.
> >
> > Once (if) this lands, the only remaining direct usage of {in,out}[bwl]
> > in xserver will be xf86SlowBcopy (jokes).  This also makes it plausible
> > to convert the rest of the drivers to the pciaccess API, which then
> > means we can drop roughly 137% of the content of compiler.h.
> >
> > ---
> >
> > The following changes since commit c768cdda92696b636c10bb2df64167d5274b4b99:
> >
> >  Merge remote branch 'jamey/reviewed' (2010-09-13 16:48:33 -0700)
> >
> > are available in the git repository at:
> >
> >  ssh://people.freedesktop.org/~ajax/xserver.git ioaddress
> I merged patches 6 and 12 from the ioaddress branch since #12 just added a
> lost } from #6. Patch 2 had some tab/space mess which I also fixed.
> Let's get this reviewed so we can kill compiler.h.
> Thanks,
> Matt
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110918/03be0e41/attachment.pgp>

More information about the xorg-devel mailing list