[PATCH 1/9] dmx: Fix a non-constant printf format string warning.

Alan Coopersmith alan.coopersmith at oracle.com
Sat Sep 17 09:48:11 PDT 2011

On 09/17/11 08:55, Matt Turner wrote:
> I suppose that change is OK, but I seem to remember a conversation on
> this list that concluded that those non-const printf format warnings
> are quite often bogus. In this case, the code looks obviously correct,
> the only problem is that stupid warning.

It's really just telling you it can't do the normal printf format string
analysis because it doesn't know the string.   If the user can control
the string, then it can be a security vulnerability or program crasher,
otherwise, it's just lost the opportunity to check that your arguments
match the number & type specified in the format string, which may hide
other errors or may just be noise in the build logs you no longer want
to see.

	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System

More information about the xorg-devel mailing list