[PATCH] fb: Rename wfbTriangles and wfbTrapezoids

[Aaron Plattner]

On Thu, Sep 15, 2011 at 07:29:18PM -0700, Alan Coopersmith wrote:
> On 09/14/11 15:25, Aaron Plattner wrote:
> > These symbols were not renamed when they were added to libfb:
> >
> >   # nm -D libwfb.so | grep ' fb'
> >   0000000000028d00 T fbTrapezoids
> >   0000000000028d60 T fbTriangles
> >
> > This causes corruption and/or crashes on wfb-ful drivers like nvidia:
> 
> Is there any simple/portable way to automate the name list generation or
> at least test that it's correctly done at build time?  It would be nice
> to not have to worry about manual updates being needed for every change.
> 
> On Solaris, I can get the equivalent output with:
> 
> % nm -pg libwfb.so | grep ' fb'
> 00000000000000218380 T fbTrapezoids
> 00000000000000219112 T fbTriangles

Yeah, it's definitely fragile.  I think the suggestion of doing this grep
at build time is probably the way to go.  Even if it doesn't work on
Windows, having it checked on FreeBSD, Solaris, and Linux is probably good
enough.  I'll see if I can get that to work at some point.

> but I'm not sure that's the best test, and clearly would need portability
> help.   wfb seems like a candidate for -export-symbols-regex '^wfb.*' but
> then it would be even harder to detect problems.
> 
> If nothing else, should there be a comment early on in fb/*.h advising
> people when a wfbrename.h entry would be needed?

Can't hurt.

> And presumably because of the crashes this is a 1.11 stable release
> candidate as well, right?

Yes please.