[PATCH xserver 8/8] Remove unused vtSysreq

[Jamey Sharp]

On Thu, Sep 15, 2011 at 06:42:59PM -0700, Alan Coopersmith wrote:
> On 09/15/11 13:07, Jamey Sharp wrote:
> >It looks to me like you should also delete VTSYSRQ from
> >hw/xfree86/parser/xf86tokens.h.
> 
> Please ensure that any changes result in the X server simply ignoring
> the VTSysReq option in existing xorg.conf and not erroring out & refusing
> to start on a file that happens to have a no-longer-useful option in.

If I understand the parser correctly (and I probably don't), it's
already too late for that: while there's a VTSYSRQ entry in the enum in
xf86tokens.h, nothing generates that token type. Instead, there's a
VTSysReq ServerFlag. So deleting the token from the enum is not a
regression, I think.

I can't figure out at a quick glance whether unknown ServerFlags are
treated as an error, though. Does the patch need to somehow make this
flag be explicitly ignored if present?

Jamey
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110915/bf3ad5f9/attachment.pgp>