[PATCH xserver 1/8] bsd: Remove unused macros KBD_FD

Jeremy Huddleston jeremyhu at apple.com
Thu Sep 15 13:02:21 PDT 2011


I review this in the sense that the comments match the src changes and look well formed.  Hopefully another BSD developer can vouch for whether they actually "do the right thing" rather than just "do the stated thing"

Reviewed-by: Jeremy Huddleston <jeremyhu at apple.com>

On Sep 15, 2011, at 12:20 PM, Alexandr Shadchin wrote:

> Signed-off-by: Alexandr Shadchin <Alexandr.Shadchin at gmail.com>
> ---
> hw/xfree86/os-support/bsd/bsd_bell.c |    4 ----
> 1 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/hw/xfree86/os-support/bsd/bsd_bell.c b/hw/xfree86/os-support/bsd/bsd_bell.c
> index 55eb752..fb457db 100644
> --- a/hw/xfree86/os-support/bsd/bsd_bell.c
> +++ b/hw/xfree86/os-support/bsd/bsd_bell.c
> @@ -37,10 +37,6 @@
> #include "xf86Priv.h"
> #include "xf86_OSlib.h"
> 
> -#ifdef WSCONS_SUPPORT
> -#define KBD_FD(i) ((i).kbdFd != -1 ? (i).kbdFd : (i).consoleFd)
> -#endif
> -
> void
> xf86OSRingBell(int loudness, int pitch, int duration)
> {
> -- 
> 1.7.6
> 
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel



---
Jeremy Huddleston

Rebuild Sudan
 - Board of Directors
 - http://www.rebuildsudan.org

Berkeley Foundation for Opportunities in Information Technology
 - Advisory Board
 - http://www.bfoit.org



More information about the xorg-devel mailing list