[PATCH 2/3] xorg-server.pc.in: Remove libpciaccess and pixman-1 from Requires

Jeremy Huddleston jeremyhu at apple.com
Thu Sep 15 02:41:38 PDT 2011


On Sep 15, 2011, at 3:30 AM, Julien Cristau wrote:

> On Thu, Sep 15, 2011 at 03:20:02 -0500, Jeremy Huddleston wrote:
> 
>> Wouldn't it be nice if the servers that we cared about were in the xorg-server tree itself, so I could try building with these changes on a linux machine to see what broke.  Oh wait, if we had the drivers in the tree to begin with we wouldn't need to do that anyways...
>> 
>> In all seriousness, yes.  This change is in xserver in this run on my tinderbox:
>> http://tinderbox.x.org/builds/2011-09-15-0003
>> 
>> I just kicked it off now, so hopefully it'll give us some idea of the impact in the morning and I can address that before this is pulled into the server.  Does this satisfy you enough for an Ack?
>> 
> Not really, missing -lfoo won't result in build failures anyway.


Actually, it looks like a bunch of drivers are not linking correctly to begin with, and nobody seems so have cared.  My guess is that this is "just working" on Linux because of the flat namespace.  Note that my example here is from my distro, not my jhbuild.  Because of this, I'll create the list of ones that should be fixed, but I don't think that concern should block the commit.

/usr/lib/xorg/modules/drivers $ ldd nouveau_drv.so
	linux-vdso32.so.1 =>  (0x00100000)
	libdrm_nouveau.so.1 => /lib/powerpc-linux-gnu/libdrm_nouveau.so.1 (0x6ff84000)
	libudev.so.0 => /lib/powerpc-linux-gnu/libudev.so.0 (0x6ff56000)
	librt.so.1 => /lib/powerpc-linux-gnu/librt.so.1 (0x6ff2d000)
	libc.so.6 => /lib/powerpc-linux-gnu/libc.so.6 (0x6fd99000)
	libdrm.so.2 => /lib/powerpc-linux-gnu/libdrm.so.2 (0x6fd6d000)
	libpthread.so.0 => /lib/powerpc-linux-gnu/libpthread.so.0 (0x6fd32000)
	/lib/ld.so.1 (0x203cd000)

/usr/lib/xorg/modules/drivers $ nm -D nouveau_drv.so | grep pixman_
         U pixman_region_copy
         U pixman_region_intersect
         U pixman_region_translate



More information about the xorg-devel mailing list