[RFC PATCH 0/9] Bus layer cleanups

Jeremy Huddleston jeremyhu at apple.com
Wed Sep 14 10:03:21 PDT 2011


I'm interested in this patch series since I'm working to get Xorg building on darwin and need to get the IOADDRESS type of shared code.  This is a pre-req for Tiago's --enable-pciaccess changes which I've rebased on recent master.

This series still applies except for the following:
[PATCH 5/9] vgahw: Port to pciaccess IO space routines
[PATCH 6/9] pci: Port xf86MapLegacyIO to pciaccess
[PATCH 7/9] linux: Use pci_device_get_parent_bridge instead of open-coding it

Adam, would you mind rebasing these and sending them out again for review?  For now I'm just going to work with Tiago's version which just does s/IOADDRESS/unsigned long/

--Jeremy

On Sep 21, 2010, at 6:28 PM, Adam Jackson wrote:

> This attempts to tackle Tiago's (justified) hatred for the IOADDRESS type
> in a slightly more elegant way.  We move more of the VGA hacks to vgahw,
> port it and int10 over to pciaccess' legacy I/O API, and then clean up
> some of the remaining detritus.
> 
> THIS IS AN ABI BREAK.  Like, a pretty massive one.  Please do not pull
> this yet.  I'm mostly looking for r-b's here that the strategy looks
> sane.  The driver work needs to land before this lands, and it's pretty
> trivial, but I don't want to bother unless this is actually going to
> merge.
> 
> Once (if) this lands, the only remaining direct usage of {in,out}[bwl]
> in xserver will be xf86SlowBcopy (jokes).  This also makes it plausible
> to convert the rest of the drivers to the pciaccess API, which then
> means we can drop roughly 137% of the content of compiler.h.
> 
> ---
> 
> The following changes since commit c768cdda92696b636c10bb2df64167d5274b4b99:
> 
>  Merge remote branch 'jamey/reviewed' (2010-09-13 16:48:33 -0700)
> 
> are available in the git repository at:
> 
>  ssh://people.freedesktop.org/~ajax/xserver.git ioaddress
> 
> Adam Jackson (9):
>      xfree86: Move xf86GetClocks to vgahw
>      int10: Port to pciaccess' legacy IO API
>      vgahw: Move IO domain setup to IO dispatch vector setup
>      vgahw: Don't default to standard (port space) access routines
>      vgahw: Port to pciaccess IO space routines
>      pci: Port xf86MapLegacyIO to pciaccess
>      linux: Use pci_device_get_parent_bridge instead of open-coding it
>      bus: remove some dead struct fields
>      linux: Remove pre-2.6 PCI interface support
> 
> hw/xfree86/common/xf86.h              |    6 -
> hw/xfree86/common/xf86Bus.c           |    1 -
> hw/xfree86/common/xf86Bus.h           |    1 -
> hw/xfree86/common/xf86Helper.c        |   90 ---------------
> hw/xfree86/common/xf86pciBus.c        |   17 ++-
> hw/xfree86/common/xf86str.h           |    1 -
> hw/xfree86/int10/generic.c            |    5 +-
> hw/xfree86/int10/helper_exec.c        |   36 +++---
> hw/xfree86/int10/xf86int10.c          |   61 +++++-----
> hw/xfree86/int10/xf86int10.h          |    2 +-
> hw/xfree86/os-support/bus/Pci.c       |    2 +-
> hw/xfree86/os-support/bus/Pci.h       |   16 +--
> hw/xfree86/os-support/bus/bsd_pci.c   |    9 +--
> hw/xfree86/os-support/bus/linuxPci.c  |  200 +--------------------------------
> hw/xfree86/os-support/bus/xf86Pci.h   |    4 +-
> hw/xfree86/os-support/shared/vidmem.c |    6 -
> hw/xfree86/vgahw/vgaHW.c              |  178 ++++++++++++++++++++++-------
> hw/xfree86/vgahw/vgaHW.h              |   24 ++--
> 18 files changed, 221 insertions(+), 438 deletions(-)
> 
> ---
> 
> - ajax
> 
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel



More information about the xorg-devel mailing list