[PATCH 2/2] xfree86: Work around issue where ar may be told to make an archive with no contents

Gaetan Nadon memsize at videotron.ca
Tue Sep 13 16:54:00 PDT 2011


On Tue, 2011-09-13 at 17:50 -0500, Jeremy Huddleston wrote:

> Signed-off-by: Jeremy Huddleston <jeremyhu at apple.com>
> ---
>  hw/xfree86/os-support/bus/Makefile.am |    2 +-
>  hw/xfree86/os-support/bus/nobus.c     |    1 +
>  2 files changed, 2 insertions(+), 1 deletions(-)
>  create mode 100644 hw/xfree86/os-support/bus/nobus.c
> 
> diff --git a/hw/xfree86/os-support/bus/Makefile.am b/hw/xfree86/os-support/bus/Makefile.am
> index 643cb25..ab813f2 100644
> --- a/hw/xfree86/os-support/bus/Makefile.am
> +++ b/hw/xfree86/os-support/bus/Makefile.am
> @@ -16,7 +16,7 @@ PLATFORM_SOURCES = Sbus.c
>  sdk_HEADERS += xf86Sbus.h
>  endif
>  
> -libbus_la_SOURCES = $(PCI_SOURCES) $(PLATFORM_SOURCES)
> +libbus_la_SOURCES = $(PCI_SOURCES) $(PLATFORM_SOURCES) nobus.c
>  
>  INCLUDES = $(XORG_INCS)
>  
> diff --git a/hw/xfree86/os-support/bus/nobus.c b/hw/xfree86/os-support/bus/nobus.c
> new file mode 100644
> index 0000000..ad23f52
> --- /dev/null
> +++ b/hw/xfree86/os-support/bus/nobus.c
> @@ -0,0 +1 @@
> +static void __noop_to_appease_ar__() { return; }


Automake:

        "Be careful when selecting library components conditionally. Because building 
        an empty library is not portable, you should ensure that any library 
        always contains at least one object."


Reviewed-by: Gaetan Nadon <memsize at videotron.ca>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110913/6be2ab0d/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110913/6be2ab0d/attachment.pgp>


More information about the xorg-devel mailing list