[PATCH mga] Nothing uses clientlx.c, so delete it.

Adam Jackson ajax at redhat.com
Tue Sep 13 16:23:33 PDT 2011

On Tue, 2011-09-13 at 16:12 -0500, Jamey Sharp wrote:
> As far as I can tell, none of this code has been used since the
> beginning of git history.

Hey, so, remember back in the dark ages when dualhead was this insanely
wild differentiating feature?  Matrox thought it was so special, in
fact, that they hid most of the implementation of it (and a bunch of
other stuff) in a binary-only blob called the HALlib.  As you'd expect
it was pretty much a cut-and-paste of the relevant Windows code, and
then some open glue to keep it working; clientlx.c is that glue.

I guess the theory was that if you don't tell people which registers to
duplicate to implement a second pipe in their own hardware, they won't
figure it out?  A pretty eyeroll-worthy idea even at the time, and
definitely not something we should be condoning anymore.

Kill it with fire, but while you're at it, untangle the hideous mess of
MGA_HAL() macros too.

Reviewed-by: Adam Jackson <ajax at redhat.com>

- ajax

More information about the xorg-devel mailing list