[PATCH libXt 2/2] Add XtErrorDB directory to pkg-config file.

[Gaetan Nadon]

On Fri, 2011-09-09 at 07:43 +0000, Egbert Eich wrote:

> On Thu, Sep 08, 2011 at 06:03:18PM -0400, Gaetan Nadon wrote:
> > On Thu, 2011-09-08 at 16:44 +0200, Egbert Eich wrote:
> > 
> > Which expands to:
> > 
> >         datarootdir=${prefix}/share
> >         datadir=${datarootdir}
> >         errordbdir=${datarootdir}/X11
> 
> So the 'datadir=' line isn't needed unless we do
> 
> ERRORDBDIR='${datadir}/X11'

Which is what you have coded in configure.ac. I recall you changed it
from datarootdir. I was somewhat surprised to see it changed to
datarootdir in the Makefile:

        datadir = ${datarootdir}
        datarootdir = ${prefix}/share
        ...
        ERRORDBDIR = ${datarootdir}/X11


There is some history being all this. The datarootdir variable has not
always existed and datadir had to be kept backward compatible. The
semantic of datarootdir is the most appropriate for errordb location. It
is the "root directory of architecture independent data". If I set a
value for datarootdir, all subdirectories (doc, locales, man pages, and
errordbdir) are relocated as well. The datadir= line is not needed in
the pc file. The makefile did the "migration" from datadir to
datarootdir.


        "In Autoconf 2.60, the set of directory variables has changed, and the defaults of some variables have been adjusted 
        (see Installation Directory Variables) to changes in the GNU Coding Standards. 
        Notably, datadir, infodir, and mandir are now expressed in terms of datarootdir"



> 
> in configure.ac
> 
> > 
> > You may also leave it as is and I can clean it later with appdefaultdir
> 
> 
> While we are at it I can just as well fix my patch ;)
> Will resend.
> 
> Cheers,
> 	Egbert.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110909/671d88b2/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110909/671d88b2/attachment.pgp>