[PATCH] configure.ac: Add -fno-strict-aliasing to CFLAGS

[Gaetan Nadon]

On Mon, 2011-10-17 at 21:21 +0200, Julien Cristau wrote:

> On Mon, Oct 17, 2011 at 11:37:08 -0700, Jeremy Huddleston wrote:
> 
> > This should force the server to have -fno-strict-aliasing even once it
> > is removed from the warning flags.
> > 
> > See: https://bugs.freedesktop.org/show_bug.cgi?id=31238
> > 
> > Signed-off-by: Jeremy Huddleston <jeremyhu at apple.com>
> > ---
> >  configure.ac |    6 ++++++
> >  1 files changed, 6 insertions(+), 0 deletions(-)
> > 
> > diff --git xorg-server-1.11.1/configure.ac xorg-server-1.11.1/configure.ac
> > index 4656a83..538aa88 100644
> > --- xorg-server-1.11.1/configure.ac
> > +++ xorg-server-1.11.1/configure.ac
> > @@ -87,6 +87,12 @@ XORG_PROG_RAWCPP
> >  # easier overrides at build time.
> >  XSERVER_CFLAGS='$(CWARNFLAGS)'
> >  
> > +dnl Explicitly add -fno-strict-aliasing since this option should disappear
> > +dnl from util-macros CWARNFLAGS
> > +if  test "x$GCC" = xyes ; then
> > +    XSERVER_CFLAGS="$XSERVER_CFLAGS -fno-strict-aliasing"
> > +fi
> > +
> >  dnl Check for dtrace program (needed to build Xserver dtrace probes)
> >  dnl Also checks for <sys/sdt.h>, since some Linux distros have an 
> >  dnl ISDN trace program named dtrace
> 
> ack in principle, although the comment is going to look slightly odd
> if/when CWARNFLAGS actually drops the flag.

The most likely follow-on step is to add another variable which contains
only warning flags as CWARNFLAGS cannot be changed in a way that would
affect previously released tarballs. There is no easy or elegant way to
fix the current situation.

The CWARNFLAGS variable would be deprecated and left alone for backward
compatibility. All actively maintained modules would replace it with the
new variable.

> 
> Cheers,
> Julien


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20111021/b5fb6526/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20111021/b5fb6526/attachment-0001.pgp>