[PATCH 12/12] exa: initialise mask_off_x and mask_off_y
Alan Coopersmith
alan.coopersmith at oracle.com
Thu Oct 20 16:02:23 PDT 2011
On 10/20/11 03:44, Dave Airlie wrote:
> From: Dave Airlie<airlied at redhat.com>
>
> These get used at the end of the function in a calculation,
> even the result isn't used its not pretty.
I can't quite follow the second line of that comment - the xMask & yMask
calculation results are passed to the pExaScr->info->Composite function,
do you mean that it doesn't use them?
> pointed out by coverity.
>
> Signed-off-by: Dave Airlie<airlied at redhat.com>
> ---
> exa/exa_render.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/exa/exa_render.c b/exa/exa_render.c
> index 6f2af8a..6ca7a2a 100644
> --- a/exa/exa_render.c
> +++ b/exa/exa_render.c
> @@ -649,7 +649,7 @@ exaTryDriverComposite(CARD8 op,
> RegionRec region;
> BoxPtr pbox;
> int nbox;
> - int src_off_x, src_off_y, mask_off_x, mask_off_y, dst_off_x, dst_off_y;
> + int src_off_x, src_off_y, mask_off_x = 0, mask_off_y = 0, dst_off_x, dst_off_y;
> PixmapPtr pSrcPix = NULL, pMaskPix = NULL, pDstPix;
> ExaPixmapPrivPtr pSrcExaPix = NULL, pMaskExaPix = NULL, pDstExaPix;
>
Reviewed-by: Alan Coopersmith <alan.coopersmith at oracle.com>
--
-Alan Coopersmith- alan.coopersmith at oracle.com
Oracle Solaris Platform Engineering: X Window System
More information about the xorg-devel
mailing list