[PATCH] Xnest: Remove socket and its lock file on exit

Julien Cristau jcristau at debian.org
Thu Oct 20 12:08:48 PDT 2011


Sorry I didn't catch this before it hit master, but:

On Mon, Oct 10, 2011 at 12:19:19 -0700, Jeremy Huddleston wrote:

> diff --git a/hw/xnest/Events.c b/hw/xnest/Events.c
> index 619427d..2399313 100644
> --- a/hw/xnest/Events.c
> +++ b/hw/xnest/Events.c
> @@ -198,6 +198,8 @@ xnestCollectEvents(void)
>      case DestroyNotify:
>        if (xnestParentWindow != (Window) 0 &&
>  	  X.xdestroywindow.window == xnestParentWindow)
> +	CloseWellKnownConnections();
> +	OsCleanup(1);
>  	exit (0);
>        break;
>  
That looks broken, don't you need braces around the if branch?  Also I'm
not quite sure what's the point of doing manual cleanup when you're
going to exit() on the next line anyway.  So this hunk looks like it
should be reverted.

Cheers,
Julien


More information about the xorg-devel mailing list