[PATCH 09/12] xv: test correct number of requests.

Alan Coopersmith alan.coopersmith at oracle.com
Thu Oct 20 07:29:05 PDT 2011


On 10/20/11 03:44, Dave Airlie wrote:
> From: Dave Airlie<airlied at redhat.com>
>
> Pointed out by coverity.
>
> Signed-off-by: Dave Airlie<airlied at redhat.com>
> ---
>   Xext/xvdisp.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Xext/xvdisp.c b/Xext/xvdisp.c
> index 364a90c..71bf722 100644
> --- a/Xext/xvdisp.c
> +++ b/Xext/xvdisp.c
> @@ -1238,7 +1238,7 @@ ProcXvDispatch(ClientPtr client)
>
>     UpdateCurrentTime();
>
> -  if (stuff->data>  xvNumRequests) {
> +  if (stuff->data>= xvNumRequests) {
>       SendErrorToClient(client, XvReqCode, stuff->data, 0, BadRequest);
>       return BadRequest;
>     }

Looks like the same fix is needed at line 1545 in the swapped version.

-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System



More information about the xorg-devel mailing list