[PATCH] test: fix input test
Jeremy Huddleston
jeremyhu at apple.com
Sat Oct 15 21:22:32 PDT 2011
FWIW, I pulled this (with Daniel's suggestions) into my "for-keith" branch which I'm sure will get merged "eventually"...
On Oct 12, 2011, at 3:24 AM, Daniel Stone wrote:
> Hi,
>
> On 12 October 2011 09:59, Dave Airlie <airlied at gmail.com> wrote:
>> The test was memsetting the wrong thing, this fixes make check in my tinderbox.
>
> Rather.
>
>> +++ b/test/input.c
>> @@ -1315,11 +1315,11 @@ static void dix_get_master(void)
>> memset(&kbd, 0, sizeof(DeviceIntRec));
>> memset(&floating, 0, sizeof(DeviceIntRec));
>>
>> - memset(&vcp_sprite, 0, sizeof(DeviceIntRec));
>> - memset(&vck_sprite, 0, sizeof(DeviceIntRec));
>> - memset(&ptr_sprite, 0, sizeof(DeviceIntRec));
>> - memset(&kbd_sprite, 0, sizeof(DeviceIntRec));
>> - memset(&floating_sprite, 0, sizeof(DeviceIntRec));
>> + memset(&vcp_sprite, 0, sizeof(SpriteInfoRec));
>> + memset(&vck_sprite, 0, sizeof(SpriteInfoRec));
>> + memset(&ptr_sprite, 0, sizeof(SpriteInfoRec));
>> + memset(&kbd_sprite, 0, sizeof(SpriteInfoRec));
>> + memset(&floating_sprite, 0, sizeof(SpriteInfoRec));
>
> But changing these to:
> memset(&vcp_sprite, 0, sizeof(vcp_sprite));
> et al would be even better ...
>
> With that:
> Reviewed-by: Daniel Stone <daniel at fooishbar.org>
>
> Cheers,
> Daniel
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
---
Jeremy Huddleston
Rebuild Sudan
- Board of Directors
- http://www.rebuildsudan.org
Berkeley Foundation for Opportunities in Information Technology
- Advisory Board
- http://www.bfoit.org
More information about the xorg-devel
mailing list