PATCH document -background none option
Michal Suchanek
hramrach at centrum.cz
Thu Oct 13 05:06:28 PDT 2011
On 12 October 2011 02:40, Alan Coopersmith <alan.coopersmith at oracle.com> wrote:
> On 10/ 7/11 05:41 AM, Michal Suchanek wrote:
>>
>> On 6 October 2011 23:39, Alan Coopersmith<alan.coopersmith at oracle.com>
>> wrote:
>>>
>>> On 10/ 6/11 07:54 AM, Michal Suchanek wrote:
>>>>
>>>> this patch documents the option introduced in commit 8976e97.
>>>
>>>> +++ b/hw/xfree86/man/Xorg.man
>>>
>>> Since the option is in the core server argument processing (os/utils.c,
>>> not under hw/xfree86/common), it should probably go in man/Xserver.man
>>> which is referenced for common args from the
>>> Xorg/Xwin/Xvfb/Xnest/Xephyr/etc.
>>> man pages.
>>
>> This updated patch puts the option in the common man page.
>
> Thanks. If you don't mind a little grammar nitpicking, a couple
> suggestions:
>
>> +.BI \-background " none"
>> +If the driver supports it it will be asked to not clear the background on
>> X startup.
>
> Having "it" twice in a row, referring to different things is a bit awkward.
> Perhaps:
>
> Asks the driver not to clear the background on startup, if the driver
> supports
> that.
>
>> +May be useful for smooth transition with eg. fbdev driver.
>> +For security reasons this is not the default. The screen content might
>> show previous user session.
>
> I'd change that to:
> For security reasons this is not the default, as the screen contents
> might show a previous user session.
Are you sure there's supposed to be a comma?
I don't pretend to understand how punctuation is placed in English but
I have seen very few commas in this place.
Thanks
Michal
More information about the xorg-devel
mailing list