[PATCH] os: Print a newline when Error is called

[Alan Coopersmith]

On 10/10/11 07:04 PM, Peter Hutterer wrote:
> On Mon, Oct 10, 2011 at 06:47:56PM -0700, Jeremy Huddleston wrote:
>>
>> On Oct 10, 2011, at 18:24, Peter Hutterer wrote:
>>
>>> There are only very few callers. IMO we should replace them with
>>>     ErrorF("%s", strerror(errno));
>>> and remove this one completely.
>>
>> Except that it is exported:
>>
>> os.h:extern _X_EXPORT void Error(const char *str);
>>
>> How about deprecating it in 1.12 and revisiting for removal in 1.13?
>
> I only have a limited checkout (input drivers + big video drivers) and can't
> find a caller. We could remove it now, we're still in the merge window.

I didn't find any calls in the nm output for my current git-master builds of:

drivers/apm_drv.so
drivers/ark_drv.so
drivers/ast_drv.so
drivers/chips_drv.so
drivers/cirrus_alpine.so
drivers/cirrus_drv.so
drivers/cirrus_laguna.so
drivers/dummy_drv.so
drivers/fbdev_drv.so
drivers/glint_drv.so
drivers/i128_drv.so
drivers/mach64_drv.so
drivers/mga_drv.so
drivers/neomagic_drv.so
drivers/newport_drv.so
drivers/nv_drv.so
drivers/r128_drv.so
drivers/rendition_drv.so
drivers/s3_drv.so
drivers/s3virge_drv.so
drivers/savage_drv.so
drivers/siliconmotion_drv.so
drivers/sis_drv.so
drivers/tdfx_drv.so
drivers/tga_drv.so
drivers/trident_drv.so
drivers/tseng_drv.so
drivers/vesa_drv.so
drivers/voodoo_drv.so
drivers/xgi_drv.so

input/kbd_drv.so
input/mouse_drv.so
input/synaptics_drv.so
input/void_drv.so

Plus a fairly recent binary package (280.13) of:

drivers/nvidia_drv.so
extensions/NVIDIA/libglx.so.1


-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System