[PATCH xwininfo 0/4] Cleanups and warning fixes
Alan Coopersmith
alan.coopersmith at oracle.com
Wed Oct 5 14:45:52 PDT 2011
On 10/ 5/11 02:22 PM, Guillem Jover wrote:
> Hi!
>
> So, while the static variable in window_id_str() is not ideal, the other
> options seemed uglier, so I went with that as it does not matter at all
> in this case.
>
> regards,
> guillem
>
> Guillem Jover (4):
> Move leading ": " out from buffer to the error string printer
> Use format string literals instead of variables to print window ids
> Refactor atom name printing into a new Display_Atom_Name function
> Use format string literals instead of variables to print atom names
>
> dsimple.c | 38 +++++++++++-----------
> xwininfo.c | 101 +++++++++++++++++++++++++++++++-----------------------------
> 2 files changed, 71 insertions(+), 68 deletions(-)
>
Looks good, thanks.
For the series:
Reviewed-by: Alan Coopersmith <alan.coopersmith at oracle.com>
--
-Alan Coopersmith- alan.coopersmith at oracle.com
Oracle Solaris Platform Engineering: X Window System
More information about the xorg-devel
mailing list