[PATCH:libpciaccess] Solaris: Give better error on realloc failure

Mark Kettenis mark.kettenis at xs4all.nl
Wed Oct 5 01:19:11 PDT 2011


> From: Alan Coopersmith <alan.coopersmith at oracle.com>
> Date: Tue,  4 Oct 2011 22:53:20 -0700
> 
> commit a18460b385ae03 converted from a fixed maximum number of devices
> to dynamically growing the list via realloc, but didn't update the
> error message shown on failure.

Hmm, I hate libraries that print messages on stderr like this.  But
printing half-truths is even worse.  So if you need one:

Reviewed-by: Mark Kettenis <kettenis at openbsd.org>

> Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
> ---
>  src/solx_devfs.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)


More information about the xorg-devel mailing list