[PATCH xf86-video-vmware] Use dixLookupWindow instead of LookupWindow on Xorg 1.5 & later

Thomas Hellstrom thellstrom at vmware.com
Wed Oct 5 00:40:15 PDT 2011


On 10/01/2011 06:07 PM, Alan Coopersmith wrote:
> On 09/27/11 07:31 PM, Alan Coopersmith wrote:
>> +static inline int
>> +dixLookupWindow(WindowPtr *pWin, XID id, ClientPtr client, Mask access)
>> +{
>> +    *pWin = LookupWindow(stuff->window, client);
>
> Oops, just noticed that should be LookupWindow(id, client); since the 
> caller
> has "stuff" and passes stuff->window there.
>
> (I did mention not even testing it built on the pre-Xorg-1.5 versions 
> that
>  only have the old API, right?)
>
No worries, we usually compile-test back to xorg-server 1.0 before pushing.

/Thomas



More information about the xorg-devel mailing list