[PULL] build fix, GC clipping cleanup

Michal Suchanek hramrach at centrum.cz
Tue Oct 4 09:19:54 PDT 2011


On 4 October 2011 18:07, Keith Packard <keithp at keithp.com> wrote:
> On Mon, 3 Oct 2011 23:46:10 -0700, Jamey Sharp <jamey at minilop.net> wrote:
>
>>       Quit wrapping ChangeClip, CopyClip, and DestroyClip in GCFuncs.
>
> Good fix
>
>>       Make GC clientClip always be a region.
>
> Good fix.
>
>>       Introduce ReleasePixmap to unreference, call screen hooks, and free.
>
> This one seems very problematic. You've essentially changed the
> semantics of the DestroyPixmap screen function without changing it's
> name or type signature. Catching mis-use of this is going to be a
> challenge.
>

Wasn't it just renamed from DestroyPixmap to ReleasePixmap?

Thanks

Michal


More information about the xorg-devel mailing list