Maintaining backwards compatibility with swap macros

[Michal Suchanek]

On 4 October 2011 17:18, Daniel Stone <daniel at fooishbar.org> wrote:
> Hi,
>
> On 4 October 2011 16:00, Michal Suchanek <hramrach at centrum.cz> wrote:
>> On 4 October 2011 16:57, Matt Turner <mattst88 at gmail.com> wrote:
>>> On Tue, Oct 4, 2011 at 2:55 PM, Michal Suchanek <hramrach at centrum.cz> wrote:
>>>> On 4 October 2011 16:51, Matt Turner <mattst88 at gmail.com> wrote:
>>>>> On Tue, Oct 4, 2011 at 2:33 PM, Michal Suchanek <hramrach at centrum.cz> wrote:
>>>>>> BTW it adds a warning about stuff variable being unused  - probably
>>>>>> defined in one of the macros.
>>>>>
>>>>> It's because the swap macros stopped taking a second argument.
>>>>
>>>> No, that would be the 'n' variable which you patched out already.
>>>
>>> Then I have no idea what you're talking about.
>>>
>> ../../Xext/xselinux_ext.c: In function ‘SProcSELinuxQueryVersion’:
>> ../../Xext/xselinux_ext.c:529:5: warning: unused variable ‘stuff’
>> [-Wunused-variable]
>
> 'stuff' is the request variable generated by the REQUEST_* macros
> (stupid name, I know).  Since SProcSELinuxQueryVersion no longer
> touches the macro, you can just delete the REQUEST_* macro and make it
> simply return ProcSELinuxQueryVersion(client).
>
Yes, removing that also fixes the warning.

Attaching updated patch.

Thanks

Michal
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-xselinux-after-swap-change.patch
Type: text/x-patch
Size: 1087 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20111004/a65cc57b/attachment.bin>