[PATCH] Save major/minor opcodes in ClientRec for RecordAReply

[Alan Coopersmith]

On 11/14/11 14:24, walter harms wrote:
>>   #ifdef XSERVER_DTRACE
>> -		XSERVER_REQUEST_DONE(LookupMajorName(MAJOROP), MAJOROP,
>> +		XSERVER_REQUEST_DONE(LookupMajorName(client->majorOp), client->majorOp,
>>   			      client->sequence, client->index, result);
>>   #endif
>
>
> It seems that XSERVER_REQUEST_DONE depends on XSERVER_DTRACE perhaps you can do a
> #ifndef SERVER_DTRACE
> #define XSERVER_REQUEST_DONE()
> #endif
>
> and keep the #ifdef XSERVER_DTRACE stuff outside the code ?

You could, but having it there makes it clearer that this is the dtrace probe
and saves those building without dtrace support from having to hunt down what
that macro is.   (Unfortunately, the macro names used are autogenerated, and
while I suppose we could #define DTRACE_REQUEST_DONE XSERVER_REQUEST_DONE to
rename it, I never really thought about doing that.)

In any case, that would be a different patch for someone to submit, not
something Keith should tackle in this one.

-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System