[PATCH:xmodmap 3/3] Replace chk_malloc + sprintf with asprintf

walter harms wharms at bfs.de
Mon Nov 14 14:29:31 PST 2011



Am 13.11.2011 18:27, schrieb Alan Coopersmith:
> On 11/12/11 01:14, walter harms wrote:
>>     Exit(-1); translates into exit(-1);  (Why ?)
>>     this does not work as intended. maybe 1 or EXIT_FAILURE is better
>> here.   
> 
> It's what the original code had and I didn't think about changing it.
> xmodmap doesn't document exit values, so I think any non-zero value
> is about the same here, even if it's a -1 that gets translated to a
> unsigned char value.
> 

Do you mind to change it into EXIT_FAILURE ?
-1 was wrong when the code was written and is now.

re,
 wh


More information about the xorg-devel mailing list