[PATCH] Fix ShmPutImage for XYBitmap
pacman at kosh.dhis.org
pacman at kosh.dhis.org
Sat Nov 5 16:20:46 PDT 2011
Julien Cristau writes:
>
> We can't call CopyArea in that case because the image has depth 1, which
> might not match the target drawable, so we might overrun the shm
> segment. Commit 11817a881cb93a89788105d1e575a468f2a8d27c apparently
> fixed a similar bug for XYPixmap, but missed the bitmap case.
>
> Fixes: http://bugs.debian.org/629611
I'll confirm that this fixes all the test cases I can think of, including the
original xli problem.
Would it hurt to also fix fbCopyArea so that unexpected depth mismatches do
something cleaner than segfault?
--
Alan Curry
More information about the xorg-devel
mailing list