[PATCH xserver 1/4] bsd: Remove bsd_pci.c

[Alan Coopersmith]

On 10/29/11 11:36, Alexandr Shadchin wrote:
> On Sat, Oct 29, 2011 at 10:13:48AM -0700, Alan Coopersmith wrote:
>> On 10/29/11 08:54, Alexandr Shadchin wrote:
>>> bsd_pci.c have only one function osPciInit(). osPciInit() is equivalent
>>> call xf86InitVidMem(). xf86InitVidMem() is needed only for OpenBSD
>>> (see commit 06c0372c3a1b45005eb6d50406f77f4e93f1de1e)
>>
>> Pretty sure Solaris needs xf86InitVidMem too, though I'm not in a position
>> to test today.   Any reason not to just set it to xf86InitVidMem for all
>> the platforms that used to call it in bsd_pci.c ?
>>
>
> Yes, it can be done, but main idea of adding xf86InitVidMem, that it was
> necessary to share aperture_fd between xserver and libpciaccess (call
> pci_system_init_dev_mem()). This is need (and implemented) only for OpenBSD.
>
> As far as I can see, this is not necessary for Solaris, but I'll be happy
> if you do test.

Okay, I don't know why Solaris would need to share, and unfortunately my
testing just found segfaults with or without your patch due to the recently
merged dependencies on the new pciaccess legacy functions that were only
implemented for Linux.

-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System